Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [BUGFIX] #112: Remove wrapping p-tag from images via TS #129

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

mcmulman
Copy link
Contributor

@mcmulman mcmulman commented Apr 4, 2021

RTE Images within links shouldn't be wrapped by an p tag, that's not valid HTML.
One solution is to disable it via TypoScript Setup.
Therefore the order of including the static TS file must be customizable.

Fixes #112

@mcmulman mcmulman changed the title [BUGFIX] #112: Remove wrapping p-tag from images via TS WIP: [BUGFIX] #112: Remove wrapping p-tag from images via TS Apr 4, 2021
@mcmulman
Copy link
Contributor Author

mcmulman commented Apr 4, 2021

lib.parseFunc_RTE.nonTypoTagStdWrap.encapsLines.encapsTagList := addToList(img)
is doing the trick, but the TS has to be included BEFORE fluid_styled_content TS, which seems wrong.

I have no glue about TS... so either this one line should be included at the end in your custom template or the whole extensions TS needs to be fixed.

Another solution would be, to remove the wrapping p tag within the linked image parser like here:
issue-112_remove-wrapping-p-tag

@CybotTM CybotTM merged commit b2bb458 into master Dec 6, 2021
@CybotTM CybotTM deleted the issue-112_disable-image-wrapper-via-ts branch December 16, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images with links wrong rendering
2 participants