Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix/145]Fix disabled button. #149

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

lucmuller
Copy link

Solution is parsing of every toolbars, then checking if the command is
'image'. If yes, put the button state at 'off' since button.getState
returns undefined

Solution is parsing of every toolbars, then checking if the command is
'image'. If yes, put the button state at 'off' since button.getState
returns undefined
@lucmuller
Copy link
Author

Don't know why, but I had the ability to create 2 PR with my commit ?

Not so much used to git pull request process. I din't find a way to contribute directly to the 10.2.0 tag had to commit to V10 branch. But seems leggit.

@CybotTM
Copy link
Member

CybotTM commented Dec 31, 2021

Hi @lucmuller,

Don't know why, but I had the ability to create 2 PR with my commit ?

Yes, of course, you can create as many PR as you like from a single commit.

I din't find a way to contribute directly to the 10.2.0 tag had to commit to V10 branch. But seems leggit.

That's correct, you cannot create PR with a tag (single commit) as target. You can only create a PR with a branch as target - which is usually master/main. But in our case it is TYPO3_10.

@CybotTM CybotTM merged commit f8254a9 into netresearch:TYPO3_10 Dec 31, 2021
@CybotTM
Copy link
Member

CybotTM commented Dec 31, 2021

@lucmuller lucmuller deleted the bugfix/145-10.2.0 branch December 31, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants