Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/rte images softreferenceindexer #161

Merged

Conversation

saitho
Copy link
Contributor

@saitho saitho commented Apr 20, 2022

This PR is based on #133 (as I can't modify the draft) and should fix #157.

But I'm not sure how to properly test this right now.
Also the $this->parserKey check may be obsolete as the service is only registered for this key.

@CybotTM CybotTM merged commit 20297bb into netresearch:master Apr 20, 2022
@CybotTM
Copy link
Member

CybotTM commented Apr 20, 2022

Thank you @saitho and @susannemoog

@fishbone1
Copy link

I get an error when saving pages depending on the rich text content. For example a paragraph with text and a table below is a problem. Only a table (without paragraph) works.

This error is caused by RteImagesSoftReferenceIndex / TypolinkSoftReferenceParser. So I hope this PR fixes it.

When will there be a new release? Is there a way to require the master from composer?

@saitho
Copy link
Contributor Author

saitho commented May 4, 2022

@fishbone1

When will there be a new release? Is there a way to require the master from composer?

I also hope for a new release. ;)

Actually you can require master in composer: You need to add this Git repository as repository in your composer.json first.
Then you can set dev-master as dependency which is the master branch.

"repositories": [
	{ "type": "git", "url": "https://github.com/netresearch/t3x-rte_ckeditor_image.git" }
],
"require": [
	"netresearch/rte-ckeditor-image": "dev-master as 11.0.3"
]

@saitho saitho deleted the bugfix/rte_images_softreferenceindexer branch October 18, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo3 11 Update Refindex fails
4 participants