Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fixes #254: handle deleted files #255

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[BUGFIX] Fixes #254: handle deleted files #255

merged 1 commit into from
Jan 4, 2024

Conversation

hannesbochmann
Copy link

@hannesbochmann hannesbochmann commented Nov 17, 2023 •
edited
Loading

This change simply catches the exception TYPO3 may throw when trying to retrieve a already deleted file.

fixes #254

Gitsko
Gitsko reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@Gitsko Gitsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a logger also

@Gitsko Gitsko removed the request for review from AndreasMueller75 January 4, 2024 10:23
@Gitsko Gitsko changed the base branch from main to TYPO3_11 January 4, 2024 10:29
@Gitsko Gitsko merged commit 6990dcb into netresearch:TYPO3_11 Jan 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gitsko Gitsko Gitsko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception thrown when element has deleted file references
2 participants
@hannesbochmann @Gitsko