-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce isModuleCurrent method #240
Comments
So I prefer to create a new method, either |
dg
pushed a commit
that referenced
this issue
Jan 3, 2020
dg
pushed a commit
that referenced
this issue
Jan 3, 2020
dg
pushed a commit
that referenced
this issue
Jan 4, 2020
dg
pushed a commit
that referenced
this issue
Jan 4, 2020
dg
pushed a commit
that referenced
this issue
Jan 4, 2020
dg
pushed a commit
that referenced
this issue
Jan 5, 2020
dg
pushed a commit
that referenced
this issue
Jan 5, 2020
dg
pushed a commit
that referenced
this issue
Jan 5, 2020
dg
pushed a commit
that referenced
this issue
Jan 15, 2020
dg
pushed a commit
that referenced
this issue
Jan 16, 2020
dg
pushed a commit
that referenced
this issue
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
I guess that many had tried to use the analogy for modules - but $presenter->isLinkCurrent('MyModule:*') throws InvalidLinkException. That looks correct to me after thinking for a while - trying to link module (not a presenter from the module) is meaningless.
Anyway I believe there should be a way how to determine the same for modules - can be handy in navigation etc.
Explain your intentions.
Provide a default solution for simple determination that I'm linking from current application module.
It's up to you to make a strong case to convince the project's developers of the merits of this feature.
When framework encourages use of modules, it can be confusing (newcomers included) that one can link to a submodule, can determine linking to current presenter but get an error when using similar notation for modules.
When looking for solution, I found two (first, second) really old related posts in forum.
Anyone can come up with his own solution so when this request is considered inappropriate, I would at least make a remark in documentation (maybe here) that it cannot be used in this way.
The text was updated successfully, but these errors were encountered: