-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use property typed by some class for persistent parameters #241
Comments
dg
added a commit
that referenced
this issue
Dec 10, 2019
dg
added a commit
that referenced
this issue
Jan 4, 2020
dg
added a commit
that referenced
this issue
Jan 4, 2020
dg
added a commit
that referenced
this issue
Jan 5, 2020
dg
added a commit
that referenced
this issue
Jan 5, 2020
dg
added a commit
that referenced
this issue
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: v3.0.2
Bug Description
Persistent parameters doesn't work in PHP 7.4 when i set some class type on property.
Steps To Reproduce
Then you get exception:
Value passed to persistent parameter 'prop' in presenter Homepage must be SomeClass, SomeClass given.
Expected Behavior
Correctly process class type on property with
@persistent
Possible Solution
Problem is here:
https://github.com/nette/application/blob/master/src/Application/UI/Component.php#L145
Third parameter is missing when required type is class.
I guess that solution should be adding 'isClass' to $meta array in here and than put it as third parameter to convertType
https://github.com/nette/application/blob/master/src/Application/UI/ComponentReflection.php#L53
The text was updated successfully, but these errors were encountered: