FileResponse: added some checks #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
reviewed
Nov 26, 2019
| @@ -40,6 +40,9 @@ public function __construct(string $file, string $name = null, string $contentTy | |||
| if (!is_file($file)) { | |||
| throw new Nette\Application\BadRequestException("File '$file' doesn't exist."); | |||
| } | |||
| if (!is_readable($file)) { | |||
| throw new Nette\Application\BadRequestException("File '$file' doesn't readable."); | |||
There was a problem hiding this comment.
I'm not sure how useful the is_readable check is when you check fopen result later anyway.
There was a problem hiding this comment.
@JanTvrdik The sooner the better :-) But I don't insist on it.
dg
reviewed
Nov 26, 2019
| @@ -88,6 +91,9 @@ public function send(Nette\Http\IRequest $httpRequest, Nette\Http\IResponse $htt | |||
|
|
|||
| $filesize = $length = filesize($this->file); | |||
| $handle = fopen($this->file, 'r'); | |||
| if (!$handle) { | |||
| throw new Nette\Application\BadRequestException("Cannot make handle of '{$this->file}'."); | |||
| } | |||
…e entire application.
tacoberu
force-pushed
the
fix-fileresponse
branch
from
f14221c to
b896510
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
7fe78c1 to
8f1bb54
Compare
dg
pushed a commit
that referenced
this pull request
Jan 3, 2020
dg
pushed a commit
that referenced
this pull request
Jan 3, 2020
dg
pushed a commit
that referenced
this pull request
Jan 4, 2020
dg
pushed a commit
that referenced
this pull request
Jan 4, 2020
dg
pushed a commit
that referenced
this pull request
Jan 4, 2020
dg
pushed a commit
that referenced
this pull request
Jan 5, 2020
dg
pushed a commit
that referenced
this pull request
Jan 5, 2020
dg
pushed a commit
that referenced
this pull request
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file has strict privileges, it will crash the entire application.