General error: 25 bind or column index out of range fix #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel that there are other places in SQLiteStorage and SQLiteJournal that should be fixed. Maybe it would be better to fix it in Cache::clean() and Cache::completeDependencies(). |
|
All right, I have just changed the casting to array list in Cache. Unfortunately, there are three errors in tests, because when trying to write dependency as a string, it is converted to array list. Tests expects it to be string though, therefore it fails. I'm not sure, if this is a problem of tests or expected behaviour. Wouldn't it be better then, to cast tags to array list inside SQLiteStorage and SQLiteJournal only? |
|
IMHO this is correct solution because storages currently rely on normalized dependencies. So it is only other normalization. |
dg
pushed a commit
that referenced
this pull request
Oct 6, 2016
dg
pushed a commit
that referenced
this pull request
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called SQLiteJournal::clean method with non-consequent integer keys, method execute had thrown exception General error: 25 bind or column index out of range.