-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader: add includes max nesting level #164
Conversation
cd28d01
to
8bbb795
Compare
For code style error created issue https://github.com/nette/coding-standard/issues/28 |
Does it make sense to include one file more than once (nested)? Ie. has sense to have INCLUDES_MAX_DEPTH larger than 1? |
I was thinking about it and it is possible that someone use config like: config.neon:
config.extensionRequiresConsole.neon:
It is probably easy to remove this 'mess' from config, but I think it is basically not wrong. |
I think it's better to add and remove files in the $loadedFiles and then only test the presence. |
4fbd76e
to
5c0db20
Compare
Pull request for #162. Solving possible call stack overflow.