Validator: relax parameter typehints #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xificurk
force-pushed
the
validator-typehints
branch
from
7d534d8 to
609763b
Compare
xificurk
force-pushed
the
validator-typehints
branch
from
609763b to
237c9fe
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
dd9d4ef to
458607d
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
ec3633f to
206edb7
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
f305a97 to
215a482
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
4c07b63 to
f59c35e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
d5e7d21 to
6b69042
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
a358616 to
cfe069b
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
49c38f3 to
c6f98c1
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
337f707 to
2146e59
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
94f43f0 to
fe374c5
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
cb844f0 to
1d8a434
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
479185b to
8da5796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some validation methods of form
Validatorrequire a specifc type of control instead of genericIControlinterface. This means you can't use those validators with custom form controls (e.g. any control based on nextras/form-components). This is especially frustrating for the basic "filled" validator which is used if the form control is marked as required.This PR relaxes the parameter typehints in backward compatible manner to allow validation of custom controls.