Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator: added support for enums #282

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Validator: added support for enums #282

merged 3 commits into from
Jan 18, 2022

Conversation

drobek94
Copy link
Contributor

No description provided.

@dg
Copy link
Member

dg commented Jan 13, 2022

Can you add a test?

@drobek94
Copy link
Contributor Author

Added.

@milo
Copy link
Member

milo commented Jan 14, 2022

UnitEnum has no value property. It has to be BackedEnum.

@drobek94
Copy link
Contributor Author

Thanks for BackedEnum.

@jakubvojacek
Copy link

This looks good, we might need this as well! Thanks @drobek94 , hope this will get merged

@dg
Copy link
Member

dg commented Jan 16, 2022

Do I understand that the point is to use enums in addRule()? Have you tested it with JavaScript?

@drobek94
Copy link
Contributor Author

Yes, it's working with JavaScript. And it's also necessary for setDefaults().

@dg
Copy link
Member

dg commented Jan 18, 2022

Thanks

@dg dg changed the title Validator update for enums support Validator: added support for enums Jan 18, 2022
@dg dg merged commit 173670e into nette:master Jan 18, 2022
dg pushed a commit that referenced this pull request Mar 29, 2022
@drobek94 @dg
Validator: added support for enums (#282)
9459dbd 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 29, 2022
@drobek94 @dg
Validator: added support for enums (#282)
0d3119d 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 29, 2022
@drobek94 @dg
Validator: added support for enums (#282)
0781b1b 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 30, 2022
@drobek94 @dg
Validator: added support for enums (#282)
3fdbb17 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 30, 2022
@drobek94 @dg
Validator: added support for enums (#282)
096baa1 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 30, 2022
@drobek94 @dg
Validator: added support for enums (#282)
93360cd 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 31, 2022
@drobek94 @dg
Validator: added support for enums (#282)
ca05e6f 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Apr 3, 2022
@drobek94 @dg
Validator: added support for enums (#282)
9f3cf85 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Apr 4, 2022
@drobek94 @dg
Validator: added support for enums (#282)
34def80 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Apr 18, 2022
@drobek94 @dg
Validator: added support for enums (#282)
08433ee 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Apr 19, 2022
@drobek94 @dg
Validator: added support for enums (#282)
88c7266 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Apr 27, 2022
@drobek94 @dg
Validator: added support for enums (#282)
221ad1c 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request May 3, 2022
@drobek94 @dg
Validator: added support for enums (#282)
d1c0117 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request May 4, 2022
@drobek94 @dg
Validator: added support for enums (#282)
2658c16 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request May 4, 2022
@drobek94 @dg
Validator: added support for enums (#282)
c564744 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request May 4, 2022
@drobek94 @dg
Validator: added support for enums (#282)
ee9cd8c 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request May 4, 2022
@drobek94 @dg
Validator: added support for enums (#282)
6137079 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 4, 2022
@drobek94 @dg
Validator: added support for enums (#282)
0a7f301 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 5, 2022
@drobek94 @dg
Validator: added support for enums (#282)
e020ea2 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 5, 2022
@drobek94 @dg
Validator: added support for enums (#282)
5dc47bf 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 27, 2022
@drobek94 @dg
Validator: added support for enums (#282)
df22305 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 27, 2022
@drobek94 @dg
Validator: added support for enums (#282)
707fe9d 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 27, 2022
@drobek94 @dg
Validator: added support for enums (#282)
9b12c28 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Dec 27, 2022
@drobek94 @dg
Validator: added support for enums (#282)
9f3f39e 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 9, 2023
@drobek94 @dg
Validator: added support for enums (#282)
ff62634 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 9, 2023
@drobek94 @dg
Validator: added support for enums (#282)
56f4843 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 9, 2023
@drobek94 @dg
Validator: added support for enums (#282)
bb6fe65 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 19, 2023
@drobek94 @dg
Validator: added support for enums (#282)
08525af 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 19, 2023
@drobek94 @dg
Validator: added support for enums (#282)
90de77d 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 19, 2023
@drobek94 @dg
Validator: added support for enums (#282)
40f7336 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 19, 2023
@drobek94 @dg
Validator: added support for enums (#282)
c1905e2 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 19, 2023
@drobek94 @dg
Validator: added support for enums (#282)
6af0182 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jan 21, 2023
@drobek94 @dg
Validator: added support for enums (#282)
036ee8a 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 2, 2023
@drobek94 @dg
Validator: added support for enums (#282)
4e8295d 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 2, 2023
@drobek94 @dg
Validator: added support for enums (#282)
9a06aeb 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 7, 2023
@drobek94 @dg
Validator: added support for enums (#282)
fd11716 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 7, 2023
@drobek94 @dg
Validator: added support for enums (#282)
2948484 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 8, 2023
@drobek94 @dg
Validator: added support for enums (#282)
400ba3c 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 8, 2023
@drobek94 @dg
Validator: added support for enums (#282)
89a50c4 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 8, 2023
@drobek94 @dg
Validator: added support for enums (#282)
0b19cf1 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 8, 2023
@drobek94 @dg
Validator: added support for enums (#282)
31a6589 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 12, 2023
@drobek94 @dg
Validator: added support for enums (#282)
6c50227 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Mar 12, 2023
@drobek94 @dg
Validator: added support for enums (#282)
e837ad4 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Jul 30, 2023
@drobek94 @dg
Validator: added support for enums (#282)
128c6da 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Aug 5, 2023
@drobek94 @dg
Validator: added support for enums (#282)
258edd1 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Oct 5, 2023
@drobek94 @dg
Validator: added support for enums (#282)
fc46163 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg pushed a commit that referenced this pull request Oct 5, 2023
@drobek94 @dg
Validator: added support for enums (#282)
a2a9c8c 
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drobek94 @dg @milo @jakubvojacek