RequestFactory: fix behavior behind proxy #81

grongor · 2016-01-31T21:06:22Z

bugfix
issues - https + nginx proxy #4
documentation - not needed
BC break - may break some edge-case server proxies, most servers should stay intact

hrach · 2016-01-31T21:07:02Z

👍

Majkl578 · 2016-01-31T21:10:55Z

👍 It just took almost 2 years to implement such simple thing. 😭

enumag · 2016-01-31T21:27:06Z

Shouldn't we do something with HTTP_X_FORWARDED_PORT as well?

Majkl578 · 2016-01-31T21:36:46Z

@enumag I was thinking exactly the same thing. How will Nette\Http\Url and/or routers work now when https mode is enabled over port 80? Wouldn't this generate nonsense like https://example.com:80/?

grongor · 2016-01-31T23:13:31Z

What do you think about that master...grongor:fix-proxy-port ?

JanTvrdik · 2016-02-01T00:47:26Z

Has anyone considered security implication?

milo · 2016-02-01T06:28:05Z

I was thinking about security in this way. The attacker can fake the HTTP_X_FORWARDED_PROTO header content. There are only two result states: http or https. These states affect the router behaviour (automatic redirections secured vs. no-flag) and URL (http:// vs https://).

Switch from http -> https: it can lead to application problem, but not security imho
Switch from https -> http: the header can be faked only outside of an SSL/TLS session, so somewhere after the proxy. But in that case you cannot trust the proxy and security does not matter.

Any other point of view?

grongor · 2016-02-01T06:46:43Z

@JanTvrdik @milo Yes, I was thinking about it the same way. If the proxy is able to mess with your headers then you can't trust it anyway - no matter what we put at server side. There might be a problem with misconfiguration of the proxy but we can't really predict that.

JanTvrdik · 2016-02-01T11:37:28Z

How does Symfony and Zend handle this?

enumag · 2016-02-01T11:45:38Z

Symfony checks if the proxy is trusted and if so it uses these headers instead.

JanTvrdik · 2016-02-01T12:06:09Z

@enumag That's what I thought.

The current trusted proxy check should be extracted and used for HTTP_X_FORWARDED_PROTO as well.

enumag · 2016-02-01T12:11:03Z

@JanTvrdik Well it seems that by default the trustedProxies array in symfony is empty. But I'm not sure if there are some added automatically elsewhere.

Majkl578 · 2016-02-01T12:20:08Z

Symfony configures trusted proxies using kernel parameter: https://github.com/symfony/symfony/blob/83b53f4a89fa2f436ba0f8d88b0714aa534b2cd2/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php#L53

grongor · 2016-02-01T21:05:31Z

I added the HTTP_X_FORWARDED_PORT handling and taken the $proxies into considerations when detecting scheme and port. Is that acceptable?

enumag · 2016-02-01T21:14:15Z

src/Http/RequestFactory.php

I'd put these outside of the foreach.

Well, I can do that but I will have to copy the $usingTrustedProxy === true condition ... do you think that removing one indention is worth it?

I just think that any logic that only happens once should be outside of a loop if possible.

Also you can skip the === true part.

That makes sense, alright :) Yeah I will, I was just trying to be clear for the purpose of comment :)

JanTvrdik · 2016-02-02T09:26:47Z

Should I point out all the issues or will @dg rewrite it anyway?

grongor · 2016-02-02T09:29:20Z

Please point out the issues, otherwise I won't learn what's wrong with this contribution :)

JanTvrdik · 2016-02-02T09:40:27Z

src/Http/RequestFactory.php

There should be space after (bool), the count call should be removed.

****, you are right, I again blindly copied the code from @Majkl578 :D

Sorry, count was a leftover, originally I had it like count(...) !== 0; but then I changed my mind. :)

JanTvrdik · 2016-02-02T09:44:13Z

Some more thoughts – I would try to remove the getSchema method entirely (inline in as it was before) and move the proxy-specific logic to where it was before.

JanTvrdik · 2016-02-02T09:51:40Z

One of reasons to keep the proxy logic together is #20

JanTvrdik · 2016-02-02T09:55:04Z

src/Http/RequestFactory.php

There should be two empty lines between two methods.

Correctly detect scheme and port if the server is behind a trusted proxy.

grongor · 2016-02-02T14:38:01Z

Thanks @JanTvrdik - I updated the code according to you suggestions and it's much easier :-) I also got rid of the "smart" scheme/port alignment. I hope I didn't miss something again ;-)

hrach · 2016-02-02T14:38:44Z

src/Http/RequestFactory.php

do a space after the casting

****, I tried so hard ... it's hard to notice these things when all other projects I'm working on use exactly opposite standards ...

still, you did an awesome work! thank you!

Majkl578 · 2016-02-02T15:00:31Z

src/Http/RequestFactory.php

This $remoteAddr !== NULL is redundant, it should go outside the callback.

JanTvrdik · 2016-02-03T10:10:34Z

src/Http/RequestFactory.php

Why change isset to !empty? Isset worked OK for years, is faster to execute, can be in PHP 7 rewritten with ?? and does not consider 0 as empty.

Because I don't think that having an empty host or address makes sense. Is that wrong assumption?

Having invalid value like '0' or '1' here makes no sense either and it's not checked anyway, maybe it could be.

That's true but I guess that we don't want to check webserver settings there. I just though that this is a little bit better (to ignore empty header rather the somehow try to use it).

dg · 2016-02-07T18:53:23Z

@grongor thanks, merged dadd667

…hind a trusted proxy [Closes #81][Closes #4]

grongor changed the title ~~RequestFactory: detect schema behind proxy correctly~~ RequestFactory: fix behavior behind proxy Feb 1, 2016

enumag reviewed Feb 1, 2016
View reviewed changes

JanTvrdik reviewed Feb 2, 2016
View reviewed changes

src/Http/RequestFactory.php Outdated

Copy link

Contributor

JanTvrdik Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be two empty lines between two methods.

RequestFactory: fix behavior behind proxy

8ca387b

Correctly detect scheme and port if the server is behind a trusted proxy.

hrach reviewed Feb 2, 2016
View reviewed changes

fixup! RequestFactory: fix behavior behind proxy

35ef4af

Majkl578 reviewed Feb 2, 2016
View reviewed changes

src/Http/RequestFactory.php Outdated

Copy link

Contributor

Majkl578 Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This $remoteAddr !== NULL is redundant, it should go outside the callback.

fixup! RequestFactory: fix behavior behind proxy

73ab79f

JanTvrdik reviewed Feb 3, 2016
View reviewed changes

fixup! RequestFactory: fix behavior behind proxy

fc5798a

dg closed this in 805ff25 Feb 7, 2016

dg pushed a commit that referenced this pull request Feb 8, 2016

RequestFactory: correctly detects scheme and port if the server is be…

dadd667

…hind a trusted proxy [Closes #81][Closes #4]

dg pushed a commit that referenced this pull request Mar 30, 2016

RequestFactory: correctly detects scheme and port if the server is be…

bdfb940

…hind a trusted proxy [Closes #81][Closes #4]

Uh oh!

RequestFactory: fix behavior behind proxy #81

RequestFactory: fix behavior behind proxy #81

Uh oh!

Conversation

grongor commented Jan 31, 2016

Uh oh!

hrach commented Jan 31, 2016

Uh oh!

Majkl578 commented Jan 31, 2016

Uh oh!

enumag commented Jan 31, 2016

Uh oh!

Majkl578 commented Jan 31, 2016

Uh oh!

grongor commented Jan 31, 2016

Uh oh!

JanTvrdik commented Feb 1, 2016

Uh oh!

milo commented Feb 1, 2016

Uh oh!

grongor commented Feb 1, 2016

Uh oh!

JanTvrdik commented Feb 1, 2016

Uh oh!

enumag commented Feb 1, 2016

Uh oh!

JanTvrdik commented Feb 1, 2016

Uh oh!

enumag commented Feb 1, 2016

Uh oh!

Majkl578 commented Feb 1, 2016

Uh oh!

grongor commented Feb 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JanTvrdik commented Feb 2, 2016

Uh oh!

grongor commented Feb 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JanTvrdik commented Feb 2, 2016

Uh oh!

JanTvrdik commented Feb 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grongor commented Feb 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dg commented Feb 7, 2016

Uh oh!

Uh oh!