Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Arrays::find() method #305

Closed
wants to merge 1 commit into from
Closed

Added Arrays::find() method #305

wants to merge 1 commit into from
+74 −0

Conversation

into-the-v0id
Copy link

@into-the-v0id into-the-v0id commented Nov 20, 2023 •
edited
Loading

This PR adds the Arrays::find() helper. It's somewhat commonly used functionality and often inconvenient and unnecessarily verbose in raw PHP.

@into-the-v0id into-the-v0id mentioned this pull request Nov 20, 2023
Closed
@dg
Copy link
Member

dg commented Nov 21, 2023

Thanks, that's a useful feature.

I'm thinking about one thing. Probably the findLast() function would come in handy over time. What about utilizing the already existing first() and last() functions and just add an optional $callback parameter to them?

@dg dg closed this in 7768aae Nov 21, 2023
dg added a commit that referenced this pull request Nov 21, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
1962ad5 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 26, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
07d6808 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 26, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
9e7321d 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 30, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
896412a 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 30, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
f0b9903 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 30, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
6b6af08 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 30, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
04e43bc 
thx @into-the-v0id
dg added a commit that referenced this pull request Nov 30, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
43b5ed0 
thx @into-the-v0id
dg added a commit that referenced this pull request Dec 5, 2023
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
0a24d76 
thx @into-the-v0id
dg added a commit that referenced this pull request Jan 17, 2024
@dg
Arrays::first() & last(): added parameter $predicate [Closes #305]
526b40c 
thx @into-the-v0id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@into-the-v0id @dg