Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix json array type #3

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix json array type #3

merged 1 commit into from
Jan 30, 2020

Conversation

stevenmiller888
Copy link
Collaborator

@nettofarah
Copy link
Owner

What exactly is changing?
I noticed that bug too, but I'm not super sure what's causing it

@stevenmiller888
Copy link
Collaborator Author

It was just hardcoded incorrectly as export interface JSONArray extends Array<JSONValue> {} in the JSONHeader variable.

@nettofarah
Copy link
Owner

Ship it!

@stevenmiller888 stevenmiller888 merged commit ca19b7d into master Jan 30, 2020
@stevenmiller888 stevenmiller888 deleted the fix/json-array branch January 30, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nettofarah nettofarah nettofarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenmiller888 @nettofarah