Ensure multiple shaded version of the same netty-tcnative artifact ca… #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
commented
Aug 23, 2018
| dnl TCN_CHECK_STATIC | ||
| dnl Will prepare more LDFLAGS that should be set to ensure we not export any functions from the static compiled APR / OpenSSL libs. | ||
| dnl | ||
| AC_DEFUN([TCN_CHECK_STATIC],[ |
There was a problem hiding this comment.
I had to do this as an autoconf function as otherwise the flags would have been picked up during running ./configure and so may fail the test to detect the linker / gcc as the filtered symbols did not exist there yet.
normanmaurer
requested review from
carl-mastrangelo,
Scottmitch,
ejona86 and
trustin
|
Also verified that you can still see all functions in a flame graph after the stripping etc :) |
Scottmitch
approved these changes
Aug 23, 2018
| @@ -275,6 +275,32 @@ dnl Note: this define must be on one line so that it can be properly returned | |||
| dnl as the help string. | |||
| AC_DEFUN([TCN_HELP_STRING],[ifelse(regexp(AC_ACVERSION, 2\.1), -1, AC_HELP_STRING($1,$2),[ ]$1 substr([ ],len($1))$2)])dnl | |||
|
|
|||
| dnl | |||
| dnl TCN_CHECK_STATIC | |||
| dnl Will prepare more LDFLAGS that should be set to ensure we not export any functions from the static compiled APR / OpenSSL libs. | |||
ejona86
approved these changes
Aug 23, 2018
…n be loaded as long as the shaded prefix is different Motivation: We should support to load multiple shaded versions of the same netty-tcnative artifact as netty-tcnative is often used in multiple dependencies. This is related to netty/netty#7272. Modifications: - Use -fvisibility=hidden when compiling and use JNIEXPORT for things we really want to have exported - Ensure fields are declared as static so these are not exported - Ensure we pass the correct linker flags so functions of the static linked version of Boring|Libre|OpenSSL and APR are not visible Result: Be able to use multiple shaded versions of the same netty-tcnative artifact.
normanmaurer
force-pushed
the
export_functions
branch
from
e31b519 to
9147afe
Compare
fzakaria
pushed a commit
to fzakaria/netty-tcnative
that referenced
this pull request
Feb 4, 2019
…n be loaded as long as the shaded prefix is different (netty#382) Motivation: We should support to load multiple shaded versions of the same netty-tcnative artifact as netty-tcnative is often used in multiple dependencies. This is related to netty/netty#7272. Modifications: - Use -fvisibility=hidden when compiling and use JNIEXPORT for things we really want to have exported - Ensure fields are declared as static so these are not exported - Ensure we pass the correct linker flags so functions of the static linked version of Boring|Libre|OpenSSL and APR are not visible Result: Be able to use multiple shaded versions of the same netty-tcnative artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n be loaded as long as the shaded prefix is different
Motivation:
We should support to load multiple shaded versions of the same netty-tcnative artifact as netty-tcnative is often used in multiple dependencies.
This is related to netty/netty#7272.
Modifications:
Result:
Be able to use multiple shaded versions of the same netty-tcnative artifact.