upgrade openssl to 3.0.8 #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasnain-db did you sign our icla yet ? https://netty.io/s/icla |
|
thanks @normanmaurer ! let me check with our corporate policies to ensure I can sign that one (I couldn't find a corporate CLA) |
|
There is also a CCLA: https://docs.google.com/forms/d/1NlOxdh1HLZeAsAcHr536apJ21UhUauyzD2oXO-j_MH4/viewform?formkey=dG9wTmhoeGNGd1MtdFdtVXl4TlVSNlE6MQ&pli=1&authuser=0 ... I just noticed databricks already signed it. |
|
great to know, thanks! is there anything additional I should do to validate this PR? |
|
@hasnain-db thanks a lot! |
|
@hasnain-db @normanmaurer wouldn't this need changes at places like : https://github.com/netty/netty-tcnative/blob/main/openssl-dynamic/pom.xml#L270? It's still pointing to openssl1, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Upgrade to a newer, better supported version of openssl. I picked 3.0.8 as it's the latest version with FIPS support (which is better for my needs) but I'm happy to change to the bleeding edge version.
Modifications:
Result:
Use up-to-date version
I tested with my own application (using the openssl-static build), happy to run other tests. I did run
./mvnw testand it passed on my machine.