support UDT

[carrot-garden]

hello there,

I am integrating udt with netty:
https://github.com/barchart/barchart-udt

I would like to reuse/extend classes from io.netty.channel.socket.nio
currently I do this by having io.netty.channel.socket.nio package in my project
due to classes being package-private;

this is no good for osgi, since same package
would have to be imported from multiple bundles;

please make io.netty.channel.socket.nio classes public?

thank you!

[normanmaurer]

@carrot-garden what exactly you extend ? Can you point me to the right place to see how you do it as I would like to see if it is a good idea to make them public :)

Also I wonder if you would be interested to issue a pull-request and have udt support directly in Netty ;)

[carrot-garden]

Norman:

great, I will re-orient my efforts towards integrating udt in netty

basically I need to inject custom selector
https://github.com/barchart/barchart-udt/blob/master/barchart-udt-core/src/main/java/com/barchart/udt/nio/SelectorUDT.java

and hence selector provider
https://github.com/barchart/barchart-udt/blob/master/barchart-udt-core/src/main/java/com/barchart/udt/nio/SelectorProviderUDT.java

into netty;

what is the right way to communicate custom selector provider to the NioEventLoop?

thanks

Andrei.

[carrot-garden]

BTW, where the integration should go? into transport
https://github.com/netty/netty/tree/master/transport
or in a separate project?

[normanmaurer]

Why not just pass it to the NioEventLoopGroup ?

https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/socket/nio/NioEventLoopGroup.java#L41

If it does not need to have any third-party dependencies it is ok to just have it in transport

[carrot-garden]

good, I will take a look.

[carrot-garden]

I made you a contributor to our netty fork:
https://github.com/barchart/netty-udt

in case you feel like creating netty-compiant skeletons :-) please do:

NioUdtChannel
NioUdtServerChannel
NioUdtDatagramChannel

BTW, will this be correct naming?

[normanmaurer]

Yes the naming sounds good... I think if you would put them in the same package we would not need to adjust the visibility. What classes would you like to extend ?

[He-Pin]

i'd like this,i just notified that we need to change the bytebuffer to channel buffer~~and the interaction with the channel handler~

[carrot-garden]

Norman:

can you please take a look if I am on the right track?

https://github.com/barchart/barchart-udt
https://github.com/barchart/barchart-udt/tree/master/barchart-udt-netty4
https://github.com/barchart/barchart-udt/tree/master/barchart-udt-netty4/src/main/java/io/netty/channel/socket

thanks,

Andrei.

[normanmaurer]

@carrot-garden looks right..

[carrot-garden]

please review #867

[He-Pin]

@carrot-garden ,for my current work,i use the bytebuffer not the channelbuffer but may make the usage of the channebuffer as an datasink and implement some frame decoder encoder and so on so i can use it with the origin bytebuffer,i see your hard work,as we both know,use netty with the barchart-udt is so nice and clean~!

i wanna help,but sorry for that i don't know how to use the this github....

thanks for your hard work,really thanks.

udt is more good than the orgin UDP and is more good and nice than TCP when the both peer is far away ~~

[carrot-garden]

@hepin1989 : 讀萬卷書不如行萬里路 - how about some pull requests? :-)

-------- Original Message --------
Subject: Re: [netty] support UDT (#844)
From: kerr notifications@github.com
To: netty/netty netty@noreply.github.com
Cc: Andrei Pozolotin Andrei.Pozolotin@gmail.com
Date: Sun 06 Jan 2013 08:49:24 PM CST

@carrot-garden https://github.com/carrot-garden ,for my current
work,i use the bytebuffer not the channelbuffer but may make the usage
of the channebuffer as an datasink and implement some frame decoder
encoder and so on so i can use it with the origin bytebuffer,i see
your hard work,as we both know,use netty with the barchart-udt is so
nice and clean~!

i wanna help,but sorry for that i don't know how to use the this
github....

thanks for your hard work,really thanks.

udt is more good than the orgin UDP and is more good and nice than TCP
when the both peer is far away ~~

—
Reply to this email directly or view it on GitHub
#844 (comment).

[He-Pin]

@carrot-garden .wowo~~!you know chinese,thanks
哈哈，你懂中文，感谢哈，我会试一试的。

[normanmaurer]

#867 was merged in.. Thanks!