Correctly override equals and hashCode for our OpenSslSession sub-types #13829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We did not correct override equals and hashcode methods for some of the OpenSslSession implementations Modifications: Override methods Result: Be able to correctly understand if a session is equal or not
|
@chrisvest I noticed this while working on the other session related PRs. |
chrisvest
approved these changes
Feb 8, 2024
normanmaurer
added a commit
that referenced
this pull request
Feb 8, 2024
…es (#13829) Motivation: We did not correct override equals and hashcode methods for some of the OpenSslSession implementations Modifications: Override methods Result: Be able to correctly understand if a session is equal or not
franz1981
pushed a commit
to franz1981/netty
that referenced
this pull request
Feb 9, 2024
…es (netty#13829) Motivation: We did not correct override equals and hashcode methods for some of the OpenSslSession implementations Modifications: Override methods Result: Be able to correctly understand if a session is equal or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We did not correct override equals and hashcode methods for some of the OpenSslSession implementations
Modifications:
Override methods
Result:
Be able to correctly understand if a session is equal or not