Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fail build on compilation error #1473

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

ddeboer
Copy link
Member

@ddeboer ddeboer commented Dec 3, 2024

npm --workspaces always returns 0, even if the command fails
for any of the workspaces: npm/rfcs#575.

Work around this by running the command on each workspace individually.

@ddeboer ddeboer enabled auto-merge (squash) December 3, 2024 13:54
@ddeboer ddeboer merged commit 8679029 into master Dec 3, 2024
2 checks passed
@ddeboer ddeboer deleted the error-on-compile-failure branch December 3, 2024 13:56
@ddeboer
Copy link
Member Author

ddeboer commented Dec 20, 2024

🎉 This PR is included in version 5.5.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Dec 20, 2024

🎉 This PR is included in version 9.19.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant