Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power: bq27xxx_battery: allow kernel poll_interval parameter runtime update #1

Merged
merged 2 commits into from
Sep 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion drivers/power/bq27xxx_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

#include <linux/device.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/param.h>
#include <linux/jiffies.h>
#include <linux/workqueue.h>
Expand Down Expand Up @@ -402,8 +403,35 @@ static struct {
BQ27XXX_PROP(BQ27421, bq27421_battery_props),
};

static DEFINE_MUTEX(bq27xxx_list_lock);
static LIST_HEAD(bq27xxx_battery_devices);

static int poll_interval_param_set(const char *val, const struct kernel_param *kp)
{
struct bq27xxx_device_info *di;
int ret;

ret = param_set_uint(val, kp);
if (ret < 0)
return ret;

mutex_lock(&bq27xxx_list_lock);
list_for_each_entry(di, &bq27xxx_battery_devices, list) {
cancel_delayed_work_sync(&di->work);
schedule_delayed_work(&di->work, 0);
}
mutex_unlock(&bq27xxx_list_lock);

return ret;
}

static const struct kernel_param_ops param_ops_poll_interval = {
.get = param_get_uint,
.set = poll_interval_param_set,
};

static unsigned int poll_interval = 360;
module_param(poll_interval, uint, 0644);
module_param_cb(poll_interval, &param_ops_poll_interval, &poll_interval, 0644);
MODULE_PARM_DESC(poll_interval,
"battery poll interval in seconds - 0 disables polling");

Expand Down Expand Up @@ -986,6 +1014,10 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)

bq27xxx_battery_update(di);

mutex_lock(&bq27xxx_list_lock);
list_add(&di->list, &bq27xxx_battery_devices);
mutex_unlock(&bq27xxx_list_lock);

return 0;
}
EXPORT_SYMBOL_GPL(bq27xxx_battery_setup);
Expand All @@ -1004,6 +1036,10 @@ void bq27xxx_battery_teardown(struct bq27xxx_device_info *di)

power_supply_unregister(di->bat);

mutex_lock(&bq27xxx_list_lock);
list_del(&di->list);
mutex_unlock(&bq27xxx_list_lock);

mutex_destroy(&di->lock);
}
EXPORT_SYMBOL_GPL(bq27xxx_battery_teardown);
Expand Down
1 change: 1 addition & 0 deletions include/linux/power/bq27xxx_battery.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ struct bq27xxx_device_info {
unsigned long last_update;
struct delayed_work work;
struct power_supply *bat;
struct list_head list;
struct mutex lock;
u8 *regs;
};
Expand Down