Issue with unevaluatedProperties with patternProperties and type union

[jkevan]

Hello, first of all thx for the great work on this library !

I discover the following issue recently using this schema:

{
  "$schema": "https://json-schema.org/draft/2019-09/schema",
  "title": "Test unevaluated properties on patternProperties",
  "type": "object",
  "patternProperties": {
    "^valid_": {
      "type": ["array", "string"],
      "items": {
        "type": "string"
      }
    }
  },
  "unevaluatedProperties": false
}

And trying to validate this data:

{
  "valid_array": ["array1_value", "array2_value"],
  "valid_string": "string_value"
}

The validation is failing due to unevaluated properties. But it should be valid.

This is mostly due to the fact that the Type validator is collecting the evaluated properties too late:

json-schema-validator/src/main/java/com/networknt/schema/TypeValidator.java

Line 124 in 9592543

addToEvaluatedProperties(at);

In current case due to Union of type we dont reach the code in charge of collecting (previous link):

json-schema-validator/src/main/java/com/networknt/schema/TypeValidator.java

Line 113 in 9592543

return unionTypeValidator.validate(node, rootNode, at);

(due to the return statement).

But anyway I found it strange to make the TypeValidator collecting for evaluated properties, shouldn't be the responsibility of the PatternPropertiesValidator like the PropertiesValidator is doing ?

Disclaimer:

• we dont have the issue in case the type is using single value and not Union, so it confirms the previous analysis.
• I tested the exact same schema and data against: https://www.jsonschemavalidator.net/ and it's correctly valid

I will try to provide unit tests scenario and a fix.

Kind regards,
Kevan.

[jkevan]

Hello,
Thank you for merging the PR so quickly !

Do you have an idea when next release will be ?

Best regards,
Kevan.

[stevehu]

I am doing some internal testing now and will release a new version after that. Stay tuned.

[jkevan]

We upgraded to latest 1.0.71 and it's all good on our side.
I'm closing the issue.

Thank you,
Best regards.