Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check type validator is of correct class #1003

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

justin-tay
Copy link
Contributor

Explicitly check that the type validator is of type TypeValidator before using to prevent a java.lang.ClassCastException in the event a meta-schema uses a different validator for instance if the standard validation vocab isn't used.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (61323ba) to head (bde0500).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1003   +/-   ##
=========================================
  Coverage     78.79%   78.80%           
- Complexity     1959     1960    +1     
=========================================
  Files           172      172           
  Lines          6344     6345    +1     
  Branches       1252     1253    +1     
=========================================
+ Hits           4999     5000    +1     
  Misses          876      876           
  Partials        469      469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit fbf11c3 into networknt:master Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants