Skip to content

issue-478 : Time format validation supports milliseconds #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2021
Merged

issue-478 : Time format validation supports milliseconds #480

merged 2 commits into from
Nov 10, 2021

Conversation

MatusSivak
Copy link
Contributor

PR changes regex pattern for time to "^\d{2}:\d{2}:\d{2}(?:\.\d+)?$"

stevehu
stevehu requested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@stevehu stevehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add test cases to ensure that both short time and full time can pass the validation? Just want to make sure that it is backward compatible. Thanks.

@stevehu stevehu merged commit dd57a89 into networknt:master Nov 10, 2021
@stevehu
Copy link
Contributor

stevehu commented Nov 10, 2021

@MatusSivak Thanks a lot for your help.

@MatusSivak
Copy link
Contributor Author

@MatusSivak Thanks a lot for your help.

No problem! Looking forward for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehu stevehu stevehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatusSivak @stevehu