Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make JsonSchemaFactory more thread-safe #891 #892

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

mpayne-coveo
Copy link
Contributor

Fixes #891.

@mpayne-coveo mpayne-coveo marked this pull request as ready for review November 14, 2023 15:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e86c817) 78.48% compared to head (c5ff909) 78.48%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #892   +/-   ##
=========================================
  Coverage     78.48%   78.48%           
  Complexity     1213     1213           
=========================================
  Files           120      120           
  Lines          3891     3891           
  Branches        746      746           
=========================================
  Hits           3054     3054           
  Misses          546      546           
  Partials        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 9ed6dc2 into networknt:master Nov 17, 2023
4 checks passed
@stevehu
Copy link
Contributor

stevehu commented Nov 17, 2023

@mpayne-coveo It makes perfect sense. Thanks a lot for your help.

@mpayne-coveo
Copy link
Contributor Author

@stevehu No problem! Any chance there can be a release cut soon? We'd like to pull this bugfix into our service if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonSchemaFactory.getSchema not thread safe
3 participants