Skip to content

Conversation

martin-sladecek
Copy link
Contributor

@martin-sladecek martin-sladecek commented Dec 7, 2023

(Hopefully) a fix for #665.
Added a special handling for "urn:" URIs
When an the same URN is present in some id/anchor, a reference is created. Otherwise, it falls back to the current logic and a special URIFetcher needs to be present.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.39%. Comparing base (2971b79) to head (ec40664).
Report is 144 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/com/networknt/schema/uri/URNURIFactory.java 25.00% 6 Missing ⚠️
src/main/java/com/networknt/schema/JsonSchema.java 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #906      +/-   ##
============================================
- Coverage     79.42%   79.39%   -0.03%     
- Complexity     1222     1229       +7     
============================================
  Files           121      122       +1     
  Lines          3897     3911      +14     
  Branches        737      740       +3     
============================================
+ Hits           3095     3105      +10     
- Misses          515      520       +5     
+ Partials        287      286       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehu stevehu merged commit b138dc6 into networknt:master Dec 8, 2023
@martin-sladecek martin-sladecek deleted the issue665 branch December 8, 2023 07:41
@martin-sladecek
Copy link
Contributor Author

Hi @stevehu, just wanted to check, when can I expect the new release to come out? Thanks!

@stevehu
Copy link
Contributor

stevehu commented Dec 8, 2023

The new release, 1.0.88, is out. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants