Support schema resource #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #922 +/- ##
============================================
- Coverage 79.04% 78.64% -0.41%
- Complexity 1390 1432 +42
============================================
Files 134 136 +2
Lines 4515 4692 +177
Branches 868 896 +28
============================================
+ Hits 3569 3690 +121
- Misses 612 645 +33
- Partials 334 357 +23 ☔ View full report in Codecov by Sentry. |
justin-tay
force-pushed
the
schemaresources_path_locale_master
branch
2 times, most recently
from
a53c3eb to
8c467d8
Compare
justin-tay
force-pushed
the
schemaresources_path_locale_master
branch
from
8c467d8 to
d356bdf
Compare
justin-tay
force-pushed
the
schemaresources_path_locale_master
branch
from
d356bdf to
afe9d78
Compare
|
@justin-tay I have released 1.2.0 vesion. Thanks a lot for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #503, closes #526, closes #918
This adds support for using schema resources in schema bundling. These changes make all required tests in the JSON Schema Test Suite from Draft 4 to 7 pass.
This also fixes some issues with the validation context, refs and enum validator.
The following comparisons are obtained using https://github.com/creek-service/json-schema-validation-comparison
Functional Comparison
Existing
fail: r:159 (3.4%) o:135 (5.7%)
fail: r:7 (1.2%) o:20 (8.0%)
fail: r:17 (2.1%) o:21 (6.6%)
fail: r:21 (2.4%) o:31 (5.7%)
fail: r:35 (2.9%) o:30 (4.8%)
fail: r:79 (6.4%) o:33 (5.2%)
With Changes
fail: r:66 (1.4%) o:128 (5.4%)
fail: r:0 (0.0%) o:19 (7.6%)
fail: r:0 (0.0%) o:19 (6.0%)
fail: r:0 (0.0%) o:29 (5.4%)
fail: r:9 (0.7%) o:29 (4.6%)
fail: r:57 (4.6%) o:32 (5.0%)
Performance Comparison
Existing
With Changes