Skip to content

Conversation

justin-tay
Copy link
Contributor

Closes #973

This makes the ethlo dependency excludable. This isn't the same as making it optional as optional dependencies need to be explicitly added, while excludable needs to be explicitly excluded.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.63%. Comparing base (bc93b44) to head (0519d3f).
⚠️ Report is 108 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/networknt/schema/format/DateTimeFormat.java 43.75% 7 Missing and 2 partials ⚠️
.../main/java/com/networknt/schema/utils/Classes.java 40.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #974      +/-   ##
============================================
- Coverage     78.75%   78.63%   -0.12%     
- Complexity     1850     1851       +1     
============================================
  Files           164      165       +1     
  Lines          5987     6001      +14     
  Branches       1146     1147       +1     
============================================
+ Hits           4715     4719       +4     
- Misses          837      846       +9     
- Partials        435      436       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehu stevehu merged commit 8c2f60b into networknt:master Feb 22, 2024
@justin-tay justin-tay deleted the ethlo_master branch March 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethlo as an optional dependency?
3 participants