Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericDataSource enhancement to allow to set HikariDataSource other setting values #970

Closed
GavinChenYan opened this issue Jun 25, 2021 · 2 comments
Closed

GenericDataSource enhancement to allow to set HikariDataSource other setting values #970

GavinChenYan opened this issue Jun 25, 2021 · 2 comments
Assignees
@GavinChenYan

Comments

@GavinChenYan
Copy link
Contributor

Currently GenericDataSource set two HikariDataSource setting

    ds.setMaximumPoolSize((Integer)mainParams.get("maximumPoolSize"));
    ds.setConnectionTimeout((Integer)mainParams.get("connectionTimeout"));

We can enhance the GenericDataSource to allow user set other values, for example:

HikariDataSource setConnectionTestQuery
HikariDataSource setLeakDetectionThreshold
...
@GavinChenYan GavinChenYan self-assigned this Jun 25, 2021
GavinChenYan added a commit that referenced this issue Jun 29, 2021
@GavinChenYan
fixes #970
2611692
@GavinChenYan GavinChenYan mentioned this issue Jun 29, 2021
Merged
GavinChenYan added a commit that referenced this issue Jun 29, 2021
@GavinChenYan
fixes #970
2f5aa9f
@GavinChenYan GavinChenYan mentioned this issue Jun 29, 2021
Merged
stevehu pushed a commit that referenced this issue Jun 29, 2021
@GavinChenYan
fixes #970 (#976)
cec0428
@stevehu
Copy link
Contributor

stevehu commented Jun 29, 2021

GenericDataSource enhancement to allow to set HikariDataSource other setting values light-4j master

@stevehu
Copy link
Contributor

stevehu commented Jun 29, 2021

GenericDataSource enhancement to allow to set HikariDataSource other setting values light-4j 1.6.x

younggwon1 pushed a commit to younggwon1/light-4j that referenced this issue Feb 10, 2024
@GavinChenYan
fixes networknt#970 (networknt#975)
af5cee3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GavinChenYan GavinChenYan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevehu @GavinChenYan