Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit handler fix #1201

Merged
merged 3 commits into from
Apr 3, 2022
Merged

Rate limit handler fix #1201

merged 3 commits into from
Apr 3, 2022

Conversation

GavinChenYan
Copy link
Contributor

After test with handler, found some error on the implementation:

  1. the rateLimit instance create for every request..
  2. nullpoint exception for the LimitQuota

@GavinChenYan GavinChenYan requested a review from stevehu April 2, 2022 22:34
@stevehu stevehu merged commit 75f16a9 into master Apr 3, 2022
@stevehu stevehu deleted the ratelimit_fix branch April 3, 2022 00:29
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
@GavinChenYan @stevehu
Rate limit handler fix (networknt#1201)
13212d7 
* add a sample limit-server.yml to help discussion

* fix the rateLimit handler error

Co-authored-by: Steve Hu <stevehu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehu stevehu stevehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GavinChenYan @stevehu