Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field groupId to connectionContext #123

Closed
Mixaster995 opened this issue Dec 21, 2021 · 3 comments
Closed

Add field groupId to connectionContext #123

Mixaster995 opened this issue Dec 21, 2021 · 3 comments

Comments

@Mixaster995
Copy link
Contributor

Description

Add new field groupId to ConnectionContext to enable possibility for mutually aware nse(which belongs to the same group)

message ConnectionContext {
    IPContext ip_context = 1; 
    DNSContext dns_context = 2; 
    EthernetContext ethernet_context = 3;
    map<string, string> extra_context = 4; 
    uint32 MTU = 5;
    string group_id =6 /*new field,*/
}

Issue

part of #121

Definition of done

  • Add new field to proto file (it has to be at the bottom)
  • Regenerate all code
@denis-tingaikin
Copy link
Member

@Mixaster995 I don't think that adding id is a good idea. Could you please explain how it will be set on the NSE side?

@edwarnicke
Copy link
Member

Can we close this issue?

@denis-tingaikin
Copy link
Member

It's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants