Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mutually aware NSEs #1203

Closed
Mixaster995 opened this issue Dec 21, 2021 · 1 comment
Closed

Enable mutually aware NSEs #1203

Mixaster995 opened this issue Dec 21, 2021 · 1 comment
Assignees
@NikitaSkrynnik

Comments

@Mixaster995
Copy link
Contributor

Mixaster995 commented Dec 21, 2021 •
edited
Loading

Description

Now excludedprefixes/client.go prevents IPs overlapping between NSEs.
We need to support use case where it is ok.
Accordingly to changes in api (networkservicemesh/api#123) modify pkg/networkservice/common/excludedprefixes/client.go chain element to enable mutually aware NSEs.
Use group_id(if it's not empty) to not add IPs issued by nse to excluded prefixes for next requests to same nse group.

Issue

part of networkservicemesh/api#121

References

chain element for modification - https://github.com/networkservicemesh/sdk/pull/1197/files#diff-feb7f1b8d36ba643d92d8e4ab16439209955c0c88b3500ef93e2479509ba69af

Definition of done

  • Modify excludedprefixes/client.go
  • Add unit testing
  • Add new chain element or modify already existing to fill group_id field on nse side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikitaSkrynnik NikitaSkrynnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mixaster995 @denis-tingaikin @NikitaSkrynnik