[qfix] Save generated kernel interface name #100
Conversation
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
qfix/kernel-if-name
branch
from
a54d6eb to
2efa62a
Compare
| @@ -100,7 +100,7 @@ func (m *Mechanism) GetInterfaceName(conn *networkservice.Connection) string { | |||
| if len(name) > LinuxIfMaxLength { | |||
| name = name[:LinuxIfMaxLength] | |||
| } | |||
| return name | |||
| m.GetParameters()[InterfaceNameKey] = name | |||
There was a problem hiding this comment.
Vlad found that in case of healing, we could re-generate the name for the interface and add it again.
@Bolodya1997 Could you explain it in detail?
There was a problem hiding this comment.
probably it is not fully correct to name the case I have tested as NSMgr restart, it is most actually a NSMgr is getting replaced with another NSMgr with the same unix/IP addresses - so the difference between is that another NSMgr has another name
in production we should get this case when we use rolling update on the NSMgr daemonset template:
- update NSMgr version
- change NSMgr envs
so it is not actually a restart, but it also should be healed as a restore
in such case new NSMgr overwrites old NSMgr path segments, so we have:
NSC -> NSMgr(1) -> Forwarder -> NSMgr(2) -> NSE
turning to
NSC -> new NSMgr(1) -> Forwarder -> new NSMgr(2) -> NSE
so when Forwarder starts trying to use new NSMgr(2) instead of NSMgr(2) for generating the link name, it generates a new name and receives a Link not found error and so fails a restore
There was a problem hiding this comment.
@edwarnicke Could you share your thoughts on why previously we do not store generated name in the parameters?
No description provided.