bump: update go to v1.18.1 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
update-go-v1.18.1
branch
from
04cc6f2 to
2ffa3cc
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
update-go-v1.18.1
branch
from
4de63ed to
c6d0a6d
Compare
denis-tingaikin
commented
Apr 25, 2022
Comment on lines
+13
to
+20
| github.com/davecgh/go-spew v1.1.0 // indirect | ||
| github.com/golang/protobuf v1.4.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| golang.org/x/net v0.0.0-20190311183353-d8887717615a // indirect | ||
| golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a // indirect | ||
| golang.org/x/text v0.3.0 // indirect | ||
| google.golang.org/genproto v0.0.0-20190819201941-24fa4b261c55 // indirect | ||
| gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c // indirect |
There was a problem hiding this comment.
Note: go 1.17 the module graph had changed --> added pruning/lazy loading.
denis-tingaikin
commented
Apr 25, 2022
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| run: | |||
| # concurrency: 6 | |||
| go: "1.17" | |||
There was a problem hiding this comment.
Closed
edwarnicke
reviewed
Apr 25, 2022
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| run: | |||
| # concurrency: 6 | |||
| go: "1.17" | |||
There was a problem hiding this comment.
Why is this 1.17 instead of 1.18.1 ?
There was a problem hiding this comment.
golangci guys are not added support for 1.18. The work in progress see at golangci/golangci-lint#2649.
We'll update this as soon as golangci will be updated.
nsmbot
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
Apr 25, 2022
…i@main PR link: networkservicemesh/api#132 Commit: 082cee0 Author: Denis Tingaikin Date: 2022-04-26 00:32:11 +0300 Message: - bump: update go to v1.18.1 (#132) * soft update to go v1.18.1 Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix ci issues Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Motivation
SOFT update to go v1.18.1