Fix Connection Selector #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
glazychev-art
approved these changes
Aug 10, 2023
denis-tingaikin
approved these changes
Aug 22, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
Aug 22, 2023
…i@main PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * minor check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add tests for MatchesMonitorScopeSelector Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
|
@edwarnicke I've merged this PR into api cuz its fixing issues with selecting. Feel free to add any comments here and we'll apply them in the separate PR. |
denis-tingaikin
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
Aug 28, 2023
…i@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Aug 28, 2023
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#164