Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use a Spire certificate instead of an automatically generated one #339

Conversation

dualBreath
Copy link

@dualBreath dualBreath commented Oct 18, 2023

Description

Add the ability to use a Spire certificate instead of an automatically generated one

Deployments part: networkservicemesh/deployments-k8s#10139

Issue link

#291

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

…y generated one

Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
@dualBreath
Copy link
Author

@denis-tingaikin, @glazychev-art, @NikitaSkrynnik, @bellycat77, Please take a look and take into account the dependent part: networkservicemesh/deployments-k8s#10139

Alexander Peretyatko added 3 commits October 18, 2023 12:08
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Alexander Peretyatko added 6 commits October 23, 2023 16:03
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Alexander Peretyatko added 4 commits November 1, 2023 12:14
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Alexander Peretyatko added 2 commits November 7, 2023 13:06
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
@denis-tingaikin denis-tingaikin merged commit e7ef571 into networkservicemesh:main Nov 24, 2023
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Nov 24, 2023
…d-admission-webhook-k8s@main

PR link: networkservicemesh/cmd-admission-webhook-k8s#339

Commit: e7ef571
Author: Denis Tingaikin
Date: 2023-11-24 12:18:25 +0300
Message:
  - Merge pull request #339 from dualBreath/task/291_use_manually_created_webhook
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants