Align env vars #421
Merged
Align env vars #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arpad Kiss <arpad.a.kiss@est.tech>
|
The failure should be fixed by networkservicemesh/.github#76 There was a different string with NSM_ prefix that was not from envconfig.Usage here, so changed the env-check, to only check lines that begin with NSM_ |
denis-tingaikin
approved these changes
May 14, 2024
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 14, 2024
…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#421 Commit: d14e0d4 Author: Denis Tingaikin Date: 2024-05-14 13:21:11 +0300 Message: - Merge pull request #421 from Nordix/arpest_update_envs Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 14, 2024
…d-admission-webhook-k8s@main (#11931) PR link: networkservicemesh/cmd-admission-webhook-k8s#421 Commit: d14e0d4 Author: Denis Tingaikin Date: 2024-05-14 13:21:11 +0300 Message: - Merge pull request #421 from Nordix/arpest_update_envs Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.