Fix unstable test + Add new test #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Oct 10, 2023
| @@ -112,14 +148,14 @@ func (eps *ExcludedPrefixesSuite) testCollectorWithFileOutput(ctx context.Contex | |||
| eps.T().Fatalf("Error transforming yaml to prefixes: %v", err) | |||
| } | |||
|
|
|||
| eps.Require().LessOrEqual(modified, len(sources)*2) | |||
There was a problem hiding this comment.
How does we calculate the modification count?
Also, seems like actual and expected should be swaped (see at input params of the function)
There was a problem hiding this comment.
I've chosen this value because for each file write there may be two nsnotify.Write events maximum. So for each source we need to have at least two possible write events.
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Oct 11, 2023
glazychev-art
approved these changes
Oct 12, 2023
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 16, 2023
…d-exclude-prefixes-k8s@main PR link: networkservicemesh/cmd-exclude-prefixes-k8s#250 Commit: c7b67bf Author: Denis Tingaikin Date: 2023-10-16 21:46:16 +0300 Message: - Merge pull request #250 from NikitaSkrynnik/fix-test Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed unstable test
TestAllSourcesWithFileOutput. Also added a new test which checks that if collector receives several notification messages but no prefixes change it won't write the same prefixes to a file several times.Issue
#180