Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for livenessProbe and readinessProbe functionality #108

Closed
rpiceage opened this issue Mar 23, 2021 · 3 comments
Closed

Request for livenessProbe and readinessProbe functionality #108

rpiceage opened this issue Mar 23, 2021 · 3 comments

Comments

@rpiceage
Copy link

Please implement some functionality that can be used as livenessProbe and readinessProbe in a helm chart, like the HTTP probes for the old-gen NSM version.
@denis-tingaikin
Copy link
Member

Hello @rpiceage

NSMgr and other endpoints using "google.golang.org/grpc/health/grpc_health_v1" server. So please consider using google.golang.org/grpc/health/grpc_health_v1 client to solve the issue.

@rpiceage
Copy link
Author

Hi @denis-tingaikin
Thanks for the quick answer and the info. We will look into this.

@denis-tingaikin
Copy link
Member

@rpiceage Be free to reopen this if the problem will actual :)

nsmbot pushed a commit that referenced this issue Nov 9, 2022
Sync files with networkservicemesh/cmd-template
afc053b 
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/d25aead01d02459c40f7c073b86440351a9fcdaf

commit d25aead01d02459c40f7c073b86440351a9fcdaf
Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com>
Date:   Wed Nov 9 16:23:14 2022 +0700

    add token to automerge workflow (#108)

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Nov 9, 2022
Sync files with networkservicemesh/cmd-template
d249268 
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/d25aead01d02459c40f7c073b86440351a9fcdaf

commit d25aead01d02459c40f7c073b86440351a9fcdaf
Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com>
Date:   Wed Nov 9 16:23:14 2022 +0700

    add token to automerge workflow (#108)

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Nov 9, 2022
Sync files with networkservicemesh/cmd-template
9d333f8 
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/d25aead01d02459c40f7c073b86440351a9fcdaf

commit d25aead01d02459c40f7c073b86440351a9fcdaf
Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com>
Date:   Wed Nov 9 16:23:14 2022 +0700

    add token to automerge workflow (#108)

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Nov 9, 2022
Sync files with networkservicemesh/cmd-template
a0c2c5e 
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/d25aead01d02459c40f7c073b86440351a9fcdaf

commit d25aead01d02459c40f7c073b86440351a9fcdaf
Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com>
Date:   Wed Nov 9 16:23:14 2022 +0700

    add token to automerge workflow (#108)

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin pushed a commit that referenced this issue Nov 9, 2022
@nsmbot
Sync files with networkservicemesh/cmd-template (#740)
1ac05ad 
This PR syncs files with https://github.com/networkservicemesh/cmd-template

Revision: https://github.com/networkservicemesh/cmd-template/commits/d25aead01d02459c40f7c073b86440351a9fcdaf

commit d25aead01d02459c40f7c073b86440351a9fcdaf
Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com>
Date:   Wed Nov 9 16:23:14 2022 +0700

    add token to automerge workflow (#108)

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

    Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denis-tingaikin @rpiceage