Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ping checking for memif #297

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix ping checking for memif #297

merged 1 commit into from
Jul 30, 2021

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 30, 2021 •
edited
Loading

Found while #284
Signed-off-by: Artem Glazychev artem.glazychev@xored.com

@glazychev-art
Fix ping checking for memif
70edc83 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@edwarnicke
Copy link
Member

Under what circumstances are we seeing 0 packets sent for ping?

@glazychev-art
Copy link
Contributor Author

@edwarnicke
Fox example, I'm catching:

vpp# ping 10.0.0.1
Failed: no source address for egress interface
Failed: no source address for egress interface
Failed: no source address for egress interface
Failed: no source address for egress interface
Failed: no source address for egress interface

Statistics: 0 sent, 0 received, 0% packet loss

@edwarnicke
Copy link
Member

Right... but that's a legit failure we should fix not paper over :)

@glazychev-art
Copy link
Contributor Author

glazychev-art commented Jul 30, 2021 •
edited
Loading

Sure. This PR is for this purpose.
Without this fix all tests will pass.

@edwarnicke edwarnicke merged commit 79b5aaf into networkservicemesh:main Jul 30, 2021
LionelJouin pushed a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Nov 16, 2023
@edwarnicke
Merge pull request networkservicemesh#297 from networkservicemesh/upd…
0e147dd 
…ate/networkservicemesh/sdk

Update from update/networkservicemesh/sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

@Bolodya1997 Bolodya1997 Awaiting requested review from Bolodya1997

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @edwarnicke