qfix: start vpp in tmp folder to avoid collisions with external vpp cases #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
|
@edwarnicke , @glazychev-art Seems to me this patch closes #533 Could you have a look? |
|
I've tested this solution. It works, but with this we lose a very handy thing: if we want to go to Instead, we need: |
| if err != nil { | ||
| logrus.Fatalf("error creating tmpDir %+v", err) | ||
| } | ||
| vppConn, vppErrCh = vpphelper.StartAndDialContext(ctx, vpphelper.WithRootDir(tmpDir)) |
There was a problem hiding this comment.
Maybe we can just use here vpphelper.WithRootDir(os.TempDir())
because it's just a local folder
nsmbot
pushed a commit
that referenced
this pull request
Apr 1, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#537 Commit: 70eceb7 Author: Chunosov Date: 2022-04-02 03:11:26 +0700 Message: - netns monitor (#537) * add netNsMonitor Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * fix linter warnings Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * fix linter warning Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * add +build linux Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * support several clients in netnt monitor Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * refactor nsmonitor Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * fix ci warnings Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * add unit-tests for nsMonitorClient Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * fix linter warning Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * sync access to test values Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * add more checks for monitoring goroutines Signed-off-by: Nikolay Chunosov <n.chunosov@yandex.ru> * fix missed sync requerd in nsmonitor tests Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…k-k8s@main PR link: networkservicemesh/sdk-k8s#537 Commit: 0e5337e Author: Network Service Mesh Bot Date: 2024-12-09 05:50:06 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#537) PR link: networkservicemesh/sdk#1689 Commit: 1e611de Author: Network Service Mesh Bot Date: 2024-12-09 05:42:24 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1689) PR link: networkservicemesh/api#180 Commit: bbb4cd5 Author: Denis Tingaikin Date: 2024-12-09 03:03:53 -0500 Message: - update go to v1.23.3 (#180) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Motivation
Closes #533