fix: Remove extra wait for srvErrCh, vppErrCh #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
|
I'm curious why not wait here for the cleanup from the srv and vpp instance? |
|
@denis-tingaikin Has the need for this gone away given the ENTRYPOINT fix you found yesterday? |
|
@edwarnicke yes this actually is not needed yet :) The root cause was in ENTRYPOINT |
nsmbot
pushed a commit
that referenced
this pull request
Apr 5, 2022
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/2d384cbd5fd350c1676480786b33e222004779f0 commit 2d384cbd5fd350c1676480786b33e222004779f0 Author: xzfc <5121426+xzfc@users.noreply.github.com> Date: Tue Apr 5 21:05:49 2022 +0000 Update golangci-lint-action to v3 (#96) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Apr 5, 2022
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/2d384cbd5fd350c1676480786b33e222004779f0 commit 2d384cbd5fd350c1676480786b33e222004779f0 Author: xzfc <5121426+xzfc@users.noreply.github.com> Date: Tue Apr 5 21:05:49 2022 +0000 Update golangci-lint-action to v3 (#96) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com