Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from update/networkservicemesh/sdk #519

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

nsmbot
Copy link
Collaborator

@nsmbot nsmbot commented Sep 12, 2022

Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1351
Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:

@nsmbot nsmbot force-pushed the update/networkservicemesh/sdk branch 3 times, most recently from 69576da to aa31275 Compare September 13, 2022 11:12
…k@main

PR link: networkservicemesh/sdk#1353

Commit: 97e00ec
Author: toby cabot
Date: 2022-09-14 19:33:40 -0400
Message:
  - Don't trace gRPC "Canceled" errors (#1353)
We were getting a *lot* of log chaff at TRACE level during normal
operation because gRPC returns a "context canceled" error periodically
but it's not really an error for us because we immediately loop around
again.

This commit uses the gRPC status.Code() method to identify these
non-errors. It also uses errors.Is() instead of == to compare error
objects. This handles wrapped errors.

https://pkg.go.dev/google.golang.org/grpc/status#Code

https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features

Signed-off-by: Toby Cabot <toby@acnodal.io>

Signed-off-by: Toby Cabot <toby@acnodal.io>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot force-pushed the update/networkservicemesh/sdk branch from aa31275 to 486d05e Compare September 14, 2022 23:34
@github-actions github-actions bot merged commit 6022b5e into main Sep 14, 2022
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Sep 14, 2022
…d-nsc-init@main

PR link: networkservicemesh/cmd-nsc-init#519

Commit: 6022b5e
Author: Network Service Mesh Bot
Date: 2022-09-14 18:38:14 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sd…
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this pull request Aug 10, 2023
…k-sriov@main

PR link: networkservicemesh/sdk-sriov#519

Commit: a86fb78
Author: Denis Tingaikin
Date: 2023-08-10 04:02:13 +0300
Message:
  - Merge pull request #519 from NikitaSkrynnik/release-act
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant