Rework client to use chain elements #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
force-pushed
the
client-chains
branch
2 times, most recently
from
5a46690 to
cad3186
Compare
Bolodya1997
force-pushed
the
client-chains
branch
3 times, most recently
from
881e985 to
56bfef7
Compare
edwarnicke
reviewed
Sep 18, 2020
edwarnicke
reviewed
Sep 18, 2020
edwarnicke
reviewed
Sep 18, 2020
edwarnicke
reviewed
Sep 18, 2020
Bolodya1997
force-pushed
the
client-chains
branch
6 times, most recently
from
effd8e7 to
d4adca8
Compare
Bolodya1997
force-pushed
the
client-chains
branch
from
122ee1c to
296c0f4
Compare
Bolodya1997
force-pushed
the
client-chains
branch
3 times, most recently
from
8fd7cfa to
f7dbef9
Compare
Bolodya1997
force-pushed
the
client-chains
branch
4 times, most recently
from
4d1e6bd to
fb01e43
Compare
edwarnicke
reviewed
Oct 30, 2020
Bolodya1997
force-pushed
the
client-chains
branch
from
de8a546 to
11e7891
Compare
Bolodya1997
force-pushed
the
client-chains
branch
5 times, most recently
from
94274ef to
6514139
Compare
denis-tingaikin
requested changes
Nov 15, 2020
added 6 commits
November 17, 2020 10:43
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
client-chains
branch
from
6514139 to
2f40595
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
denis-tingaikin
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Added few minor comments.
Will merge this when this repo will be updated by https://github.com/networkservicemesh/cmd-template (Waiting for PR networkservicemesh/cmd-template#45)
.golangci.yml
Outdated
| @@ -169,3 +169,13 @@ issues: | |||
| exclude-use-default: false | |||
| max-issues-per-linter: 0 | |||
| max-same-issues: 0 | |||
| exclude-rules: | |||
There was a problem hiding this comment.
Probably we need to disable one of two linters if they are conflicted
There was a problem hiding this comment.
Yep, don't actually sure that sloppyReassign is any useful, have disabled it.
main.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| cleanupTimeout = 10 * time.Second |
There was a problem hiding this comment.
Can we use config.ConnectTimeout ?
added 2 commits
November 20, 2020 09:23
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
denis-tingaikin
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
kernel.NewClient(),vfio.NewClient()to add client chain elements, no need to duplicate such code.Solution: