Adapt cmd-nsc to use opentracing #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tigran Manasyan <tigran.manasyan@xored.com>
tigrulya-exe
force-pushed
the
add-jaeger-tracing
branch
from
4edb41f to
56e3e83
Compare
edwarnicke
reviewed
Oct 22, 2020
main.go
Outdated
|
|
||
| cmdSpan := spanhelper.FromContext(ctx, "Init nsc") |
There was a problem hiding this comment.
Please don't. Use log.Entry(ctx) for this sort of logging.
There was a problem hiding this comment.
Used log.Entry(ctx) for nsc initialization logs
tigrulya-exe
force-pushed
the
add-jaeger-tracing
branch
from
56e3e83 to
ed55499
Compare
Signed-off-by: Tigran Manasyan <tigran.manasyan@xored.com>
tigrulya-exe
force-pushed
the
add-jaeger-tracing
branch
from
ed55499 to
ab5c638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging directly with logrus was replaced with logging via spanhelper.Logger()