Initial client #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
denis-tingaikin
approved these changes
Aug 21, 2020
edwarnicke
reviewed
Aug 21, 2020
| func main() { | ||
| // ******************************************************************************** |
There was a problem hiding this comment.
I like this style of comment... it provides good visual blocking.
edwarnicke
reviewed
Aug 21, 2020
| } | ||
|
|
||
| // NewNSMClient - creates a client connection to NSMGr | ||
| func NewNSMClient(ctx context.Context, rootConf *config.Config) networkservice.NetworkServiceClient { |
There was a problem hiding this comment.
I really like NewNSMClient being here in main.go ... it makes it easy to see in one place what you are doing, but breaks things up nicely. It’s a good compromise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial client and environment variables to use.
Signed-off-by: Andrey Sobolev haiodo@gmail.com