Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS Server #453

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Jun 28, 2022

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Issue

#451

@NikitaSkrynnik NikitaSkrynnik marked this pull request as draft June 28, 2022 11:39
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review July 18, 2022 07:28
main.go Outdated
}
go dnsutils.ListenAndServe(ctx, dnsServerHandler, c.LocalDNSServerAddress)

var dnsClient = dnscontext.NewClient(dnscontext.WithChainContext(ctx), dnscontext.WithDNSConfigsMap(dnsConfigsMap))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to the client chain at line 201?

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit f5ada81 into networkservicemesh:main Jul 18, 2022
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Jul 18, 2022
…d-nsc@main

PR link: networkservicemesh/cmd-nsc#453

Commit: f5ada81
Author: Nikita Skrynnik
Date: 2022-07-19 02:54:24 +1100
Message:
  - Add DNS Server (#453)
* add dns server to client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* update sdk repo link + add config variable for dns server address

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* move dnscontext client to client chain

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@NikitaSkrynnik NikitaSkrynnik deleted the dns-server branch June 2, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants