generated from networkservicemesh/cmd-template
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS Server #453
Merged
denis-tingaikin
merged 6 commits into
networkservicemesh:main
from
NikitaSkrynnik:dns-server
Jul 18, 2022
Merged
Add DNS Server #453
denis-tingaikin
merged 6 commits into
networkservicemesh:main
from
NikitaSkrynnik:dns-server
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
7f40cf7
to
2a23251
Compare
main.go
Outdated
} | ||
go dnsutils.ListenAndServe(ctx, dnsServerHandler, c.LocalDNSServerAddress) | ||
|
||
var dnsClient = dnscontext.NewClient(dnscontext.WithChainContext(ctx), dnscontext.WithDNSConfigsMap(dnsConfigsMap)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to the client chain at line 201?
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Jul 18, 2022
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 18, 2022
…d-nsc@main PR link: networkservicemesh/cmd-nsc#453 Commit: f5ada81 Author: Nikita Skrynnik Date: 2022-07-19 02:54:24 +1100 Message: - Add DNS Server (#453) * add dns server to client Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * update sdk repo link + add config variable for dns server address Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix ci Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * move dnscontext client to client chain Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com
Issue
#451