Update from update/networkservicemesh/sdk-vpp #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-vpp@main PR link: networkservicemesh/sdk-vpp#452 Commit: 7958db6 Author: Ed Warnicke Date: 2021-11-22 09:09:20 -0600 Message: - Fix for mtu issues with kernelvethpair (#452) This *probably* fixes: networkservicemesh/sdk#1148 The underlying issue was that the end of the vethpair to which VPP was attaching with afpacket was not getting its MTU set correctly. As a result, if an oversized packet was sent over it, it would be fragmented by the kernel to a size that matches the mtu on the end of the veth pair that was in the NSC network namespace. The resulting packet would *still* be to large for the MTU of the end of the vethpair attached to the VPP instance, and would be dropped there. The second fragment, being smaller, would be smaller than the MTU of the end of the vethpair to which VPP was attached with af-packet, and so get through. Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nsmbot
pushed a commit
that referenced
this pull request
Apr 23, 2024
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/7369b5fd24fe89c8021d5dcf3f5aea3393a64805 commit 7369b5fd24fe89c8021d5dcf3f5aea3393a64805 Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com> Date: Tue Apr 23 20:12:10 2024 +0700 Delete check-release-branch job from release workflow (#130) * Delete check-release-branch job from release workflow Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * minor fixes Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
that referenced
this pull request
Apr 23, 2024
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/7369b5fd24fe89c8021d5dcf3f5aea3393a64805 commit 7369b5fd24fe89c8021d5dcf3f5aea3393a64805 Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com> Date: Tue Apr 23 20:12:10 2024 +0700 Delete check-release-branch job from release workflow (#130) * Delete check-release-branch job from release workflow Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * minor fixes Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#452
Commit: 7958db6
Author: Ed Warnicke
Date: 2021-11-22 09:09:20 -0600
Message:
This probably fixes:
1st fragment dropped on VxLAN connection sdk#1148
The underlying issue was that the end of the vethpair to which
VPP was attaching with afpacket was not getting its MTU set correctly.
As a result, if an oversized packet was sent over it, it would be fragmented
by the kernel to a size that matches the mtu on the end of the veth pair
that was in the NSC network namespace.
The resulting packet would still be to large for the MTU of the end of the
vethpair attached to the VPP instance, and would be dropped there.
The second fragment, being smaller, would be smaller than the MTU of the
end of the vethpair to which VPP was attached with af-packet, and so get
through.