Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSMgr adds NSE in registry with wrong URL #101

Closed
Bolodya1997 opened this issue Nov 6, 2020 · 0 comments
Closed

NSMgr adds NSE in registry with wrong URL #101

Bolodya1997 opened this issue Nov 6, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Bolodya1997
Copy link

Issue

NSMgr adds NSE in registry with ListenOn[0] URL.

nsmMgr := &registry.NetworkServiceEndpoint{
Name: configuration.Name + "#nsmgr",
Url: configuration.ListenOn[0].String(),
}

If it is a unix socket URL, NSE is unaccessible from the remote NSMgr.

Existing 'solution' of this problem is not working because it sets URL after it has been used for the NSMgr creation:

if listenURL.Scheme == tcpSchema {
nsmMgr.Url = listenURL.String()
}

Possible solution

Use URL with tcp scheme instead of ListenOn[0] URL.

What if there are multiple public URLs for different cases?

NSMgr can use multiple public URL, example:

  1. unix socket - for communication between pods on single node
  2. LAN IP address - for communication in domain
  3. WAN IP address - for interdomain communication

Currently registry doesn't provide API to register NSE with both (2, 3) URLs, so NSE will be either unaccessible from the LAN, or from the Internet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants