Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NSMgr adds NSE in registry with wrong URL #118

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

denis-tingaikin
Copy link
Member

Motivation

This PR closes
#102
#101

Note:

For #102 can be used URL in format "tcp://:5001" whereby 5001 can be any other valid port.

…k8s daemonset can't access node IP address

Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin force-pushed the fix_issue_102 branch 2 times, most recently from 18e2a2e to e38b434 Compare November 12, 2020 09:46
Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin force-pushed the fix_issue_102 branch 2 times, most recently from c057be0 to 41e7118 Compare November 13, 2020 07:32
Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
@haiodo haiodo merged commit 8971395 into networkservicemesh:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants