qfix: Add net.Dialer with dialTimeout for nsmgr #395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Motivation
Since we are not using a
grpc.WithBlock
option in nsmgr (see at networkservicemesh/sdk#1083)The grpc is not using our dialTimeout(https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/common/dial/client.go#L52) see at
So to avoid problems with the long dial we can simply add for nsmgr dialer with a timeout.
Note: This is required for heal rework networkservicemesh/sdk#1113
To reproduce the problem with long dial just run this: